added 1 commit

• b7097223 - Consoles are not meant to be seen nor heard

Compare with previous version

added 1 commit

• e330833d - Don't interrupt the player's console

Compare with previous version

added 46 commits

• e330833d...8e5ac64d - 45 commits from branch STJr:master
• 3de4dbeb - Merge remote-tracking branch 'origin/master' into console-fixes

Compare with previous version

Oh, right, should have said ages ago; I had a look at this branch, and noticed that among it's changes, it took out both CON_ToggleOff and CON_ClearHUD from F_StartIntro, assuming the lattermost function was called only by D_SRB2Main in d_main.c, moving the two removed functions to there to optimise the code.

Turns out F_StartIntro is actually called by a few other places in fact.

added 137 commits

• 3de4dbeb...423403ea - 136 commits from branch STJr:master
• e71472ed - Merge remote-tracking branch 'origin/master' into console-fixes

Compare with previous version

Is this safe to go in, is what MI said 3 months ago blocking?

Yeah somewhat, I don't know the side effects of him removing those things from the functions indirectly.

(as in yeah it is blocking)

If I remember correctly, F_StartIntro is only called at game start or with the playintro command. In the latter case, not closing console would be part of nonobtrusiveness. I'm fine with that being changed. Perhaps one would want to play the intro uninterrupted for, say, a recording.

Closing this in favor a less design biased and more readable MR.

closed