Players with SF_DASHMODE had their normalspeed and jumpfactor defaulted each tic while they were not in dashmode. These stats are now only reset when a) dashmode tips from above the threshold into below the threshold, or b) when the player respawns.
When dashmode culminates, Metal Sonic's followmobj spawns a ghost trail - this is in fact a bug, and occurs for every character with a followmobj during dashmode. This is rectified here, and I have instead given Metal Sonic a similar but more deliberate effect.
G_PlayerRebornsaving the value of
It does so in order for
player->dashmodeto be present when the logic added to
Ah okay, though I wonder whether
P_SpawnPlayershould reset skin-related stats generally, but I guess that works (it's a bit hacky though).
This was my first time looking at the player-spawning functions, so I'm not attached to the method if you think it's unwieldy. The functions called after P_SpawnPlayer seem more to do with positioning the player and their camera, so I figured it was the best spot for it?